Skip to content

Commit

Permalink
iommu/arm-smmu: Remove duplicate error message
Browse files Browse the repository at this point in the history
Since commit 7723f4c ("driver core: platform: Add an error message
to platform_get_irq*()"), platform_get_irq() displays an error when the
IRQ isn't found. Remove the error print from the SMMU driver. Note the
slight change of behaviour: no message is printed if platform_get_irq()
returns -EPROBE_DEFER, which probably doesn't concern the SMMU.

Fixes: 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Jean-Philippe Brucker authored and Joerg Roedel committed Nov 11, 2019
1 parent f7aff1a commit 34d1b08
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/iommu/arm-smmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -2095,10 +2095,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
for (i = 0; i < num_irqs; ++i) {
int irq = platform_get_irq(pdev, i);

if (irq < 0) {
dev_err(dev, "failed to get irq index %d\n", i);
if (irq < 0)
return -ENODEV;
}
smmu->irqs[i] = irq;
}

Expand Down

0 comments on commit 34d1b08

Please sign in to comment.