Skip to content

Commit

Permalink
irqchip/imx-intmux: Handle pure domain searches correctly
Browse files Browse the repository at this point in the history
The removal of the paremeter count restriction in the core code to allow
pure domain token based select() decisions broke the IMX intmux select
callback as that unconditioally expects that there is a parameter.

Add the missing check for zero parameter count and the token match.

Fixes: de1ff30 ("genirq/irqdomain: Remove the param count restriction from select()")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/87ttm3ikok.ffs@tglx
  • Loading branch information
Thomas Gleixner committed Feb 20, 2024
1 parent 9bbe13a commit 34da27a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/irqchip/irq-imx-intmux.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ static int imx_intmux_irq_select(struct irq_domain *d, struct irq_fwspec *fwspec
if (fwspec->fwnode != d->fwnode)
return false;

/* Handle pure domain searches */
if (!fwspec->param_count)
return d->bus_token == bus_token;

return irqchip_data->chanidx == fwspec->param[1];
}

Expand Down

0 comments on commit 34da27a

Please sign in to comment.