Skip to content

Commit

Permalink
arp: fixed error in a comment
Browse files Browse the repository at this point in the history
the is_garp code deals just with gratuitous ARP packets, not every
unsolicited packet.

This patch is a result of a discussion in netdev:
http://marc.info/?l=linux-netdev&m=149506354216994

Suggested-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ihar Hrachyshka authored and David S. Miller committed May 21, 2017
1 parent 499350a commit 34eb5fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/arp.c
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ static int arp_process(struct net *net, struct sock *sk, struct sk_buff *skb)
*/
is_garp = tip == sip && addr_type == RTN_UNICAST;

/* Unsolicited ARP _replies_ also require target hwaddr to be
/* Gratuitous ARP _replies_ also require target hwaddr to be
* the same as source.
*/
if (is_garp && arp->ar_op == htons(ARPOP_REPLY))
Expand Down

0 comments on commit 34eb5fe

Please sign in to comment.