Skip to content

Commit

Permalink
drm/i915/mst: debug log 4 bytes of ESI right after reading
Browse files Browse the repository at this point in the history
For whatever reason, the ESI link service irq vector was missing from
the debug output. Add the missing byte, clean up the debug message, and
do the logging right after reading the data.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220112110319.1172110-3-jani.nikula@intel.com
  • Loading branch information
Jani Nikula committed Jan 21, 2022
1 parent 603801d commit 34ed3e8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/i915/display/intel_dp.c
Original file line number Diff line number Diff line change
Expand Up @@ -3683,6 +3683,8 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
break;
}

drm_dbg_kms(&i915->drm, "DPRX ESI: %4ph\n", esi);

/* check link status - esi[10] = 0x200c */
if (intel_dp->active_mst_links > 0 && link_ok &&
!drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) {
Expand All @@ -3691,8 +3693,6 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
link_ok = false;
}

drm_dbg_kms(&i915->drm, "got esi %3ph\n", esi);

intel_dp_mst_hpd_irq(intel_dp, esi, &handled);

if (!handled)
Expand Down

0 comments on commit 34ed3e8

Please sign in to comment.