Skip to content

Commit

Permalink
ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
Browse files Browse the repository at this point in the history
All pinctrl nodes for the Atmel pinctrl controller need to have their
bias configuration explicitly defined. Otherwise, the pinctrl mapping
is not valid.

It works for now as the pinctrl driver proceeds even with invalid
mappings, but this can become an issue, if the pinctrl driver starts
to require valid mappings. Additionally, the pin is not protected from
being remapped later by an other driver.

There is an external 1kOhms pull-up to 3.3V, so no bias is required on
the Ethernet PHY's interrupt line.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
  • Loading branch information
Romain Izard authored and Nicolas Ferre committed Mar 1, 2016
1 parent 388f7b1 commit 34ff2dc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/arm/boot/dts/at91-sama5d2_xplained.dts
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@

pinctrl_macb0_phy_irq: macb0_phy_irq {
pinmux = <PIN_PC9__GPIO>;
bias-disable;
};

pinctrl_pdmic_default: pdmic_default {
Expand Down

0 comments on commit 34ff2dc

Please sign in to comment.