Skip to content

Commit

Permalink
drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure
Browse files Browse the repository at this point in the history
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR.
Correctly handle this. Note that there is sufficient sense information to
support scsi error handling even in this case.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
  • Loading branch information
K. Y. Srinivasan authored and Christoph Hellwig committed Jul 25, 2014
1 parent f885fb7 commit 3533f86
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/scsi/storvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
case ATA_12:
set_host_byte(scmnd, DID_PASSTHROUGH);
break;
/*
* On Some Windows hosts TEST_UNIT_READY command can return
* SRB_STATUS_ERROR, let the upper level code deal with it
* based on the sense information.
*/
case TEST_UNIT_READY:
break;
default:
set_host_byte(scmnd, DID_TARGET_FAILURE);
}
Expand Down

0 comments on commit 3533f86

Please sign in to comment.