Skip to content

Commit

Permalink
crypto: cavium/nitrox - Invoke callback after DMA unmap
Browse files Browse the repository at this point in the history
In process_response_list() invoke the callback handler after unmapping
the DMA buffers. It ensures DMA data is synced form device to cpu
before the client code access the data from callback handler.

Fixes: c961333 ("crypto: cavium/nitrox - Added AEAD cipher support")
Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Nagadheeraj Rottela authored and Herbert Xu committed Jan 25, 2019
1 parent d45a90c commit 356690d
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/crypto/cavium/nitrox/nitrox_reqmgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,8 @@ static void process_response_list(struct nitrox_cmdq *cmdq)
struct nitrox_device *ndev = cmdq->ndev;
struct nitrox_softreq *sr;
int req_completed = 0, err = 0, budget;
completion_t callback;
void *cb_arg;

/* check all pending requests */
budget = atomic_read(&cmdq->pending_count);
Expand Down Expand Up @@ -564,13 +566,13 @@ static void process_response_list(struct nitrox_cmdq *cmdq)
smp_mb__after_atomic();
/* remove from response list */
response_list_del(sr, cmdq);

/* ORH error code */
err = READ_ONCE(*sr->resp.orh) & 0xff;

if (sr->callback)
sr->callback(sr->cb_arg, err);
callback = sr->callback;
cb_arg = sr->cb_arg;
softreq_destroy(sr);
if (callback)
callback(cb_arg, err);

req_completed++;
}
Expand Down

0 comments on commit 356690d

Please sign in to comment.