Skip to content

Commit

Permalink
batman-adv: replace call_rcu by kfree_rcu for simple kmem_cache_free …
Browse files Browse the repository at this point in the history
…callback

Since SLOB was removed and since
commit 6c6c47b ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"),
it is not necessary to use call_rcu when the callback only performs
kmem_cache_free. Use kfree_rcu() directly.

The changes were made using Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
  • Loading branch information
Julia Lawall authored and Simon Wunderlich committed Oct 14, 2024
1 parent 5c956d1 commit 356c81b
Showing 1 changed file with 3 additions and 44 deletions.
47 changes: 3 additions & 44 deletions net/batman-adv/translation-table.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,20 +209,6 @@ batadv_tt_global_hash_find(struct batadv_priv *bat_priv, const u8 *addr,
return tt_global_entry;
}

/**
* batadv_tt_local_entry_free_rcu() - free the tt_local_entry
* @rcu: rcu pointer of the tt_local_entry
*/
static void batadv_tt_local_entry_free_rcu(struct rcu_head *rcu)
{
struct batadv_tt_local_entry *tt_local_entry;

tt_local_entry = container_of(rcu, struct batadv_tt_local_entry,
common.rcu);

kmem_cache_free(batadv_tl_cache, tt_local_entry);
}

/**
* batadv_tt_local_entry_release() - release tt_local_entry from lists and queue
* for free after rcu grace period
Expand All @@ -237,7 +223,7 @@ static void batadv_tt_local_entry_release(struct kref *ref)

batadv_softif_vlan_put(tt_local_entry->vlan);

call_rcu(&tt_local_entry->common.rcu, batadv_tt_local_entry_free_rcu);
kfree_rcu(tt_local_entry, common.rcu);
}

/**
Expand All @@ -255,20 +241,6 @@ batadv_tt_local_entry_put(struct batadv_tt_local_entry *tt_local_entry)
batadv_tt_local_entry_release);
}

/**
* batadv_tt_global_entry_free_rcu() - free the tt_global_entry
* @rcu: rcu pointer of the tt_global_entry
*/
static void batadv_tt_global_entry_free_rcu(struct rcu_head *rcu)
{
struct batadv_tt_global_entry *tt_global_entry;

tt_global_entry = container_of(rcu, struct batadv_tt_global_entry,
common.rcu);

kmem_cache_free(batadv_tg_cache, tt_global_entry);
}

/**
* batadv_tt_global_entry_release() - release tt_global_entry from lists and
* queue for free after rcu grace period
Expand All @@ -283,7 +255,7 @@ void batadv_tt_global_entry_release(struct kref *ref)

batadv_tt_global_del_orig_list(tt_global_entry);

call_rcu(&tt_global_entry->common.rcu, batadv_tt_global_entry_free_rcu);
kfree_rcu(tt_global_entry, common.rcu);
}

/**
Expand Down Expand Up @@ -408,19 +380,6 @@ static void batadv_tt_global_size_dec(struct batadv_orig_node *orig_node,
batadv_tt_global_size_mod(orig_node, vid, -1);
}

/**
* batadv_tt_orig_list_entry_free_rcu() - free the orig_entry
* @rcu: rcu pointer of the orig_entry
*/
static void batadv_tt_orig_list_entry_free_rcu(struct rcu_head *rcu)
{
struct batadv_tt_orig_list_entry *orig_entry;

orig_entry = container_of(rcu, struct batadv_tt_orig_list_entry, rcu);

kmem_cache_free(batadv_tt_orig_cache, orig_entry);
}

/**
* batadv_tt_orig_list_entry_release() - release tt orig entry from lists and
* queue for free after rcu grace period
Expand All @@ -434,7 +393,7 @@ static void batadv_tt_orig_list_entry_release(struct kref *ref)
refcount);

batadv_orig_node_put(orig_entry->orig_node);
call_rcu(&orig_entry->rcu, batadv_tt_orig_list_entry_free_rcu);
kfree_rcu(orig_entry, rcu);
}

/**
Expand Down

0 comments on commit 356c81b

Please sign in to comment.