Skip to content

Commit

Permalink
drm/i915/gvt: Reuse the gmbus pin macro
Browse files Browse the repository at this point in the history
Reuse the gmbus pin macro from i915_reg.h file to improve readablity.

Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: fred gao <fred.gao@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
  • Loading branch information
fred gao authored and Zhenyu Wang committed Jan 10, 2019
1 parent c3b5a84 commit 360f864
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/gpu/drm/i915/gvt/edid.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ static inline int bxt_get_port_from_gmbus0(u32 gmbus0)
int port_select = gmbus0 & _GMBUS_PIN_SEL_MASK;
int port = -EINVAL;

if (port_select == 1)
if (port_select == GMBUS_PIN_1_BXT)
port = PORT_B;
else if (port_select == 2)
else if (port_select == GMBUS_PIN_2_BXT)
port = PORT_C;
else if (port_select == 3)
else if (port_select == GMBUS_PIN_3_BXT)
port = PORT_D;
return port;
}
Expand All @@ -96,13 +96,13 @@ static inline int get_port_from_gmbus0(u32 gmbus0)
int port_select = gmbus0 & _GMBUS_PIN_SEL_MASK;
int port = -EINVAL;

if (port_select == 2)
if (port_select == GMBUS_PIN_VGADDC)
port = PORT_E;
else if (port_select == 4)
else if (port_select == GMBUS_PIN_DPC)
port = PORT_C;
else if (port_select == 5)
else if (port_select == GMBUS_PIN_DPB)
port = PORT_B;
else if (port_select == 6)
else if (port_select == GMBUS_PIN_DPD)
port = PORT_D;
return port;
}
Expand Down

0 comments on commit 360f864

Please sign in to comment.