Skip to content

Commit

Permalink
media: video-i2c: drop vb2_ops_wait_prepare/finish
Browse files Browse the repository at this point in the history
Since commit 8878598 ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
  • Loading branch information
Hans Verkuil committed Oct 28, 2024
1 parent 30e932f commit 361445a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/media/i2c/video-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,6 @@ static const struct vb2_ops video_i2c_video_qops = {
.buf_queue = buffer_queue,
.start_streaming = start_streaming,
.stop_streaming = stop_streaming,
.wait_prepare = vb2_ops_wait_prepare,
.wait_finish = vb2_ops_wait_finish,
};

static int video_i2c_querycap(struct file *file, void *priv,
Expand Down

0 comments on commit 361445a

Please sign in to comment.