Skip to content

Commit

Permalink
clk: si5351: Use managed of_clk_add_hw_provider()
Browse files Browse the repository at this point in the history
Use the managed `devm_of_clk_add_hw_provider()` instead of
`of_clk_add_hw_provider()`.

This makes sure the provider gets automatically removed on unbind and
allows to completely eliminate the drivers `remove()` callback.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20230410014502.27929-10-lars@metafoo.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Stephen Boyd committed Apr 10, 2023
1 parent bda7339 commit 361dde3
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/clk/clk-si5351.c
Original file line number Diff line number Diff line change
Expand Up @@ -1641,8 +1641,8 @@ static int si5351_i2c_probe(struct i2c_client *client)
}
}

ret = of_clk_add_hw_provider(client->dev.of_node, si53351_of_clk_get,
drvdata);
ret = devm_of_clk_add_hw_provider(&client->dev, si53351_of_clk_get,
drvdata);
if (ret) {
dev_err(&client->dev, "unable to add clk provider\n");
return ret;
Expand All @@ -1651,18 +1651,12 @@ static int si5351_i2c_probe(struct i2c_client *client)
return 0;
}

static void si5351_i2c_remove(struct i2c_client *client)
{
of_clk_del_provider(client->dev.of_node);
}

static struct i2c_driver si5351_driver = {
.driver = {
.name = "si5351",
.of_match_table = of_match_ptr(si5351_dt_ids),
},
.probe_new = si5351_i2c_probe,
.remove = si5351_i2c_remove,
.id_table = si5351_i2c_ids,
};
module_i2c_driver(si5351_driver);
Expand Down

0 comments on commit 361dde3

Please sign in to comment.