Skip to content

Commit

Permalink
USB: serial: omninet: drop open callback
Browse files Browse the repository at this point in the history
Remove the now redundant open callback and let core call the generic
handler for us instead.

Signed-off-by: Johan Hovold <johan@kernel.org>
  • Loading branch information
Johan Hovold committed Mar 8, 2017
1 parent 3057241 commit 367ec17
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/usb/serial/omninet.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#define BT_IGNITIONPRO_ID 0x2000

/* function prototypes */
static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port);
static void omninet_process_read_urb(struct urb *urb);
static void omninet_write_bulk_callback(struct urb *urb);
static int omninet_write(struct tty_struct *tty, struct usb_serial_port *port,
Expand Down Expand Up @@ -60,7 +59,6 @@ static struct usb_serial_driver zyxel_omninet_device = {
.attach = omninet_attach,
.port_probe = omninet_port_probe,
.port_remove = omninet_port_remove,
.open = omninet_open,
.write = omninet_write,
.write_room = omninet_write_room,
.write_bulk_callback = omninet_write_bulk_callback,
Expand Down Expand Up @@ -140,11 +138,6 @@ static int omninet_port_remove(struct usb_serial_port *port)
return 0;
}

static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port)
{
return usb_serial_generic_open(tty, port);
}

#define OMNINET_HEADERLEN 4
#define OMNINET_BULKOUTSIZE 64
#define OMNINET_PAYLOADSIZE (OMNINET_BULKOUTSIZE - OMNINET_HEADERLEN)
Expand Down

0 comments on commit 367ec17

Please sign in to comment.