Skip to content

Commit

Permalink
net: mediatek: do not set the QID field in the TX DMA descriptors
Browse files Browse the repository at this point in the history
The QID field gets set to the mac id. This made the DMA linked list queue
the traffic of each MAC on a different internal queue. However during long
term testing we found that this will cause traffic stalls as the multi
queue setup requires a more complete initialisation which is not part of
the upstream driver yet.

This patch removes the code setting the QID field, resulting in all
traffic ending up in queue 0 which works without any special setup.

Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
John Crispin authored and David S. Miller committed Apr 13, 2016
1 parent 7c78b4a commit 369f045
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/mediatek/mtk_eth_soc.c
Original file line number Diff line number Diff line change
Expand Up @@ -603,8 +603,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev,
WRITE_ONCE(txd->txd1, mapped_addr);
WRITE_ONCE(txd->txd3, (TX_DMA_SWC |
TX_DMA_PLEN0(frag_map_size) |
last_frag * TX_DMA_LS0) |
mac->id);
last_frag * TX_DMA_LS0));
WRITE_ONCE(txd->txd4, 0);

tx_buf->skb = (struct sk_buff *)MTK_DMA_DUMMY_DESC;
Expand Down

0 comments on commit 369f045

Please sign in to comment.