Skip to content

Commit

Permalink
phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII
Browse files Browse the repository at this point in the history
Configure 'p_standard_mode' only for DP/QSGMII as for other modes
it's not used as per the programming sequence. Add "continue" in the
else to prevent random value from being written to p_standard_mode.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Link: https://lore.kernel.org/r/20210331131417.15596-1-kishon@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Kishon Vijay Abraham I authored and Vinod Koul committed Mar 31, 2021
1 parent d57cd79 commit 36a8138
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/phy/ti/phy-j721e-wiz.c
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ static int wiz_mode_select(struct wiz *wiz)
mode = LANE_MODE_GEN1;
else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII)
mode = LANE_MODE_GEN2;
else
continue;

ret = regmap_field_write(wiz->p_standard_mode[i], mode);
if (ret)
Expand Down

0 comments on commit 36a8138

Please sign in to comment.