Skip to content

Commit

Permalink
spi: stm32: Remove unnecessary print function dev_err()
Browse files Browse the repository at this point in the history
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

./drivers/spi/spi-stm32-ospi.c:798:2-9: line 798 is redundant because platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19220
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://patch.msgid.link/20250306024716.27856-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Jiapeng Chong authored and Mark Brown committed Mar 6, 2025
1 parent 7dfc9bd commit 3707fd9
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/spi/spi-stm32-ospi.c
Original file line number Diff line number Diff line change
Expand Up @@ -794,10 +794,8 @@ static int stm32_ospi_get_resources(struct platform_device *pdev)
}

ospi->irq = platform_get_irq(pdev, 0);
if (ospi->irq < 0) {
dev_err(dev, "Can't get irq %d\n", ospi->irq);
if (ospi->irq < 0)
return ospi->irq;
}

ret = devm_request_irq(dev, ospi->irq, stm32_ospi_irq, 0,
dev_name(dev), ospi);
Expand Down

0 comments on commit 3707fd9

Please sign in to comment.