Skip to content

Commit

Permalink
afs: Add a tracepoint to record callbacks from unlisted servers
Browse files Browse the repository at this point in the history
Add a tracepoint to record callbacks from servers for which we don't have a
record.

Signed-off-by: David Howells <dhowells@redhat.com>
  • Loading branch information
David Howells committed May 14, 2018
1 parent 001ab5a commit 3709a39
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 3 deletions.
12 changes: 9 additions & 3 deletions fs/afs/cmservice.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ static int afs_deliver_cb_callback(struct afs_call *call)
* vnodes to operate upon */
rxrpc_kernel_get_peer(call->net->socket, call->rxcall, &srx);
server = afs_find_server(call->net, &srx);
if (!server)
if (!server) {
trace_afs_cm_no_server(call, &srx);
return -ENOTCONN;
}
call->cm_server = server;

return afs_queue_call_work(call);
Expand Down Expand Up @@ -329,8 +331,10 @@ static int afs_deliver_cb_init_call_back_state(struct afs_call *call)
/* we'll need the file server record as that tells us which set of
* vnodes to operate upon */
server = afs_find_server(call->net, &srx);
if (!server)
if (!server) {
trace_afs_cm_no_server(call, &srx);
return -ENOTCONN;
}
call->cm_server = server;

return afs_queue_call_work(call);
Expand Down Expand Up @@ -400,8 +404,10 @@ static int afs_deliver_cb_init_call_back_state3(struct afs_call *call)
rcu_read_lock();
server = afs_find_server_by_uuid(call->net, call->request);
rcu_read_unlock();
if (!server)
if (!server) {
trace_afs_cm_no_server_u(call, call->request);
return -ENOTCONN;
}
call->cm_server = server;

return afs_queue_call_work(call);
Expand Down
42 changes: 42 additions & 0 deletions include/trace/events/afs.h
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,48 @@ TRACE_EVENT(afs_protocol_error,
__entry->call, __entry->error, __entry->where)
);

TRACE_EVENT(afs_cm_no_server,
TP_PROTO(struct afs_call *call, struct sockaddr_rxrpc *srx),

TP_ARGS(call, srx),

TP_STRUCT__entry(
__field(unsigned int, call )
__field(unsigned int, op_id )
__field_struct(struct sockaddr_rxrpc, srx )
),

TP_fast_assign(
__entry->call = call->debug_id;
__entry->op_id = call->operation_ID;
memcpy(&__entry->srx, srx, sizeof(__entry->srx));
),

TP_printk("c=%08x op=%u %pISpc",
__entry->call, __entry->op_id, &__entry->srx.transport)
);

TRACE_EVENT(afs_cm_no_server_u,
TP_PROTO(struct afs_call *call, const uuid_t *uuid),

TP_ARGS(call, uuid),

TP_STRUCT__entry(
__field(unsigned int, call )
__field(unsigned int, op_id )
__field_struct(uuid_t, uuid )
),

TP_fast_assign(
__entry->call = call->debug_id;
__entry->op_id = call->operation_ID;
memcpy(&__entry->uuid, uuid, sizeof(__entry->uuid));
),

TP_printk("c=%08x op=%u %pU",
__entry->call, __entry->op_id, &__entry->uuid)
);

#endif /* _TRACE_AFS_H */

/* This part must be outside protection */
Expand Down

0 comments on commit 3709a39

Please sign in to comment.