Skip to content

Commit

Permalink
dt-bindings: net: dsa: mediatek,mt7530: change mt7530 switch address
Browse files Browse the repository at this point in the history
In the case of muxing phy0 of the MT7530 switch, the switch and the phy
will have the same address on the mdio bus, 0. This causes the ethernet
driver to fail since devices on the mdio bus cannot share an address.

Any address can be used for the switch, therefore, change the switch
address to 0x1f.

Suggested-by: Sungbo Eo <mans0n@gorani.run>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Arınç ÜNAL authored and David S. Miller committed Sep 23, 2022
1 parent e8619b0 commit 3737c6a
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,9 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
switch@0 {
switch@1f {
compatible = "mediatek,mt7530";
reg = <0>;
reg = <0x1f>;
reset-gpios = <&pio 33 0>;
Expand Down Expand Up @@ -346,9 +346,9 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
switch@0 {
switch@1f {
compatible = "mediatek,mt7530";
reg = <0>;
reg = <0x1f>;
mediatek,mcm;
resets = <&ethsys MT2701_ETHSYS_MCM_RST>;
Expand Down Expand Up @@ -474,9 +474,9 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
switch@0 {
switch@1f {
compatible = "mediatek,mt7621";
reg = <0>;
reg = <0x1f>;
mediatek,mcm;
resets = <&sysc MT7621_RST_MCM>;
Expand Down Expand Up @@ -560,9 +560,9 @@ examples:
reg = <4>;
};
switch@0 {
switch@1f {
compatible = "mediatek,mt7621";
reg = <0>;
reg = <0x1f>;
mediatek,mcm;
resets = <&sysc MT7621_RST_MCM>;
Expand Down Expand Up @@ -650,9 +650,9 @@ examples:
phy-mode = "rgmii";
};
switch@0 {
switch@1f {
compatible = "mediatek,mt7621";
reg = <0>;
reg = <0x1f>;
mediatek,mcm;
resets = <&sysc MT7621_RST_MCM>;
Expand Down Expand Up @@ -730,9 +730,9 @@ examples:
phy-mode = "rgmii";
};
switch@0 {
switch@1f {
compatible = "mediatek,mt7621";
reg = <0>;
reg = <0x1f>;
mediatek,mcm;
resets = <&sysc MT7621_RST_MCM>;
Expand Down

0 comments on commit 3737c6a

Please sign in to comment.