Skip to content

Commit

Permalink
net: ethernet: ti: am65-cpsw: Call of_node_put() on error path
Browse files Browse the repository at this point in the history
This code returns directly but it should instead call of_node_put()
to drop some reference counts.

Fixes: dab2b26 ("net: ethernet: ti: am65-cpsw: Add support for SERDES configuration")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/e3012f0c-1621-40e6-bf7d-03c276f6e07f@kili.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Dan Carpenter authored and Jakub Kicinski committed Jun 14, 2023
1 parent fbf6f48 commit 374283a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/ti/am65-cpsw-nuss.c
Original file line number Diff line number Diff line change
Expand Up @@ -2068,7 +2068,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
/* Initialize the Serdes PHY for the port */
ret = am65_cpsw_init_serdes_phy(dev, port_np, port);
if (ret)
return ret;
goto of_node_put;

port->slave.mac_only =
of_property_read_bool(port_np, "ti,mac-only");
Expand Down

0 comments on commit 374283a

Please sign in to comment.