Skip to content

Commit

Permalink
tg3: Expand 4g_overflow_test workaround to skb fragments of any size.
Browse files Browse the repository at this point in the history
The current driver assumes that an skb fragment can only be upto jumbo
size. Presumably this was a fast-path optimization. This assumption is
no longer true as fragments can be upto 32k.

v2: Remove unnecessary parantheses per Eric Dumazet.

Cc: stable@vger.kernel.org
Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nithin Sujir authored and David S. Miller committed Dec 27, 2013
1 parent 1a29321 commit 3756791
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/broadcom/tg3.c
Original file line number Diff line number Diff line change
Expand Up @@ -7622,7 +7622,7 @@ static inline int tg3_4g_overflow_test(dma_addr_t mapping, int len)
{
u32 base = (u32) mapping & 0xffffffff;

return (base > 0xffffdcc0) && (base + len + 8 < base);
return base + len + 8 < base;
}

/* Test for TSO DMA buffers that cross into regions which are within MSS bytes
Expand Down

0 comments on commit 3756791

Please sign in to comment.