Skip to content

Commit

Permalink
fsi: master-ast-cf: Mask unused bits in RTAG/RCRC
Browse files Browse the repository at this point in the history
Then reading the RTAG/RCRC "registers" from the coprocessor after
a command is complete, mask out the top bits, only keep the relevant
bits. Microcode v5 will leave garbage in those top bits as a
result of a performance optimization.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
  • Loading branch information
Benjamin Herrenschmidt committed Jul 25, 2018
1 parent d0cff24 commit 375cac7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/fsi/fsi-master-ast-cf.c
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,8 @@ static int send_request(struct fsi_master_acf *master, struct fsi_msg *cmd,
static int read_copro_response(struct fsi_master_acf *master, uint8_t size,
uint32_t *response, u8 *tag)
{
uint8_t rtag = ioread8(master->sram + STAT_RTAG);
uint8_t rcrc = ioread8(master->sram + STAT_RCRC);
uint8_t rtag = ioread8(master->sram + STAT_RTAG) & 0xf;
uint8_t rcrc = ioread8(master->sram + STAT_RCRC) & 0xf;
uint32_t rdata = 0;
uint32_t crc;
uint8_t ack;
Expand Down

0 comments on commit 375cac7

Please sign in to comment.