Skip to content

Commit

Permalink
spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours
Browse files Browse the repository at this point in the history
The DSPI interrupt can be shared between two controllers at least on the
LX2160A. In that case, the driver for one controller might misbehave and
consume the other's interrupt. Fix this by actually checking if any of
the bits in the status register have been asserted.

Fixes: 13aed23 ("spi: spi-fsl-dspi: use IRQF_SHARED mode to request IRQ")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20190822211514.19288-3-olteanv@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Vladimir Oltean authored and Mark Brown committed Aug 23, 2019
1 parent 12fb61a commit 37b4100
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-fsl-dspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ static irqreturn_t dspi_interrupt(int irq, void *dev_id)
regmap_write(dspi->regmap, SPI_SR, spi_sr);

if (!(spi_sr & (SPI_SR_EOQF | SPI_SR_TCFQF)))
return IRQ_HANDLED;
return IRQ_NONE;

/* Get transfer counter (in number of SPI transfers). It was
* reset to 0 when transfer(s) were started.
Expand Down

0 comments on commit 37b4100

Please sign in to comment.