Skip to content

Commit

Permalink
selftests/ftrace: Replace echo -e with printf
Browse files Browse the repository at this point in the history
echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e 	[PASS]

Fix that by using printf instead.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
Signed-off-by: Shuah Khan <shuah@kernel.org>
  • Loading branch information
Juerg Haefliger authored and Shuah Khan committed Feb 22, 2019
1 parent 6d771c6 commit 37fb665
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions tools/testing/selftests/ftrace/ftracetest
Original file line number Diff line number Diff line change
@@ -173,8 +173,13 @@ strip_esc() {
}

prlog() { # messages
echo -e "$@"
[ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
newline="\n"
if [ "$1" = "-n" ] ; then
newline=
shift
fi
printf "$*$newline"
[ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
}
catlog() { #file
cat $1

0 comments on commit 37fb665

Please sign in to comment.