Skip to content

Commit

Permalink
ALSA: ak4117: remove redundant check on err being < 0
Browse files Browse the repository at this point in the history
snd_ak4117_create checks if the error return err is less than zero
or not.  This is a redundant check, err can only be < 0 to get to
the __fail label, in which case just return err and remove the
redundant check (since we never return -EIO).

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Colin Ian King authored and Takashi Iwai committed Jul 12, 2016
1 parent dfa40d3 commit 3805e6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/i2c/other/ak4117.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ int snd_ak4117_create(struct snd_card *card, ak4117_read_t *read, ak4117_write_t

__fail:
snd_ak4117_free(chip);
return err < 0 ? err : -EIO;
return err;
}

void snd_ak4117_reg_write(struct ak4117 *chip, unsigned char reg, unsigned char mask, unsigned char val)
Expand Down

0 comments on commit 3805e6a

Please sign in to comment.