Skip to content

Commit

Permalink
drm/i915/icl/tc: Remove the ICL special casing during TC-cold blocking
Browse files Browse the repository at this point in the history
While a TypeC port mode is locked a DISPLAY_CORE power domain reference
is held, which implies a runtime PM ref. By removing the ICL !legacy
port special casing, a TC_COLD_OFF power domain reference will be taken
for such ports, which also translates to a runtime PM ref on that
platform. A follow-up change will stop holding the DISPLAY_CORE power
domain while the port is locked.

Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210921002313.1132357-11-imre.deak@intel.com
  • Loading branch information
Imre Deak committed Sep 29, 2021
1 parent 8e8289a commit 38c3934
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/gpu/drm/i915/display/intel_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ tc_cold_block_in_mode(struct intel_digital_port *dig_port, enum tc_port_mode mod
{
struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);

if (DISPLAY_VER(i915) == 11 && !dig_port->tc_legacy_port)
return 0;

*domain = tc_cold_get_power_domain(dig_port, mode);

return intel_display_power_get(i915, *domain);
Expand Down Expand Up @@ -108,9 +105,6 @@ assert_tc_cold_blocked(struct intel_digital_port *dig_port)
struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
bool enabled;

if (DISPLAY_VER(i915) == 11 && !dig_port->tc_legacy_port)
return;

enabled = intel_display_power_is_enabled(i915,
tc_cold_get_power_domain(dig_port,
dig_port->tc_mode));
Expand Down

0 comments on commit 38c3934

Please sign in to comment.