Skip to content

Commit

Permalink
spi: fsl-espi: merge fsl_espi_trans and fsl_espi_do_trans
Browse files Browse the repository at this point in the history
Merge both functions to reduce source code size and improve
readability.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Heiner Kallweit authored and Mark Brown committed Sep 12, 2016
1 parent 06af115 commit 38d003f
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions drivers/spi/spi-fsl-espi.c
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,13 @@ static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t)
return mpc8xxx_spi->count > 0 ? -EMSGSIZE : 0;
}

static int fsl_espi_do_trans(struct spi_message *m, struct spi_transfer *trans)
static int fsl_espi_trans(struct spi_message *m, struct spi_transfer *trans)
{
struct mpc8xxx_spi *mspi = spi_master_get_devdata(m->spi->master);
struct spi_device *spi = m->spi;
int ret = 0;
int ret;

fsl_espi_copy_to_buf(m, mspi);
fsl_espi_setup_transfer(spi, trans);

ret = fsl_espi_bufs(spi, trans);
Expand All @@ -290,18 +292,6 @@ static int fsl_espi_do_trans(struct spi_message *m, struct spi_transfer *trans)

fsl_espi_setup_transfer(spi, NULL);

return ret;
}

static int fsl_espi_trans(struct spi_message *m, struct spi_transfer *trans)
{
struct mpc8xxx_spi *mspi = spi_master_get_devdata(m->spi->master);
int ret;

fsl_espi_copy_to_buf(m, mspi);

ret = fsl_espi_do_trans(m, trans);

if (!ret)
fsl_espi_copy_from_buf(m, mspi);

Expand Down

0 comments on commit 38d003f

Please sign in to comment.