Skip to content

Commit

Permalink
netfilter: nf_conntrack_bridge: Fix memory leak when error
Browse files Browse the repository at this point in the history
It should be added kfree_skb_list() when err is not equal to zero
in nf_br_ip_fragment().

v2: keep this aligned with IPv6.
v3: modify iter.frag_list to iter.frag.

Fixes: 3c171f4 ("netfilter: bridge: add connection tracking system")
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Yajun Deng authored and Pablo Neira Ayuso committed Aug 4, 2021
1 parent 5f7b51b commit 38ea9de
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions net/bridge/netfilter/nf_conntrack_bridge.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ static int nf_br_ip_fragment(struct net *net, struct sock *sk,

skb = ip_fraglist_next(&iter);
}

if (!err)
return 0;

kfree_skb_list(iter.frag);

return err;
}
slow_path:
Expand Down

0 comments on commit 38ea9de

Please sign in to comment.