Skip to content

Commit

Permalink
usb: gadget: pxa27x: fix suspend callback
Browse files Browse the repository at this point in the history
pxa27x disconnects pullups on suspend but doesn't
notify the gadget driver about it, so gadget driver
can't disable the endpoints it was using.

This causes problems on resume because gadget core
will think endpoints are still enabled and just
ignore the following usb_ep_enable().

Fix this problem by calling
gadget_driver->disconnect().

Cc: <stable@vger.kernel.org> # v3.10+
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Felipe Balbi committed Nov 19, 2015
1 parent 7fe9a93 commit 391e6dc
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/usb/gadget/udc/pxa27x_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2536,6 +2536,9 @@ static int pxa_udc_suspend(struct platform_device *_dev, pm_message_t state)
udc->pullup_resume = udc->pullup_on;
dplus_pullup(udc, 0);

if (udc->driver)
udc->driver->disconnect(&udc->gadget);

return 0;
}

Expand Down

0 comments on commit 391e6dc

Please sign in to comment.