Skip to content

Commit

Permalink
media: xilinx-tpg: use new of_graph functions
Browse files Browse the repository at this point in the history
Now we can use new port related functions for port parsing. Use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/87a5eub5s8.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
  • Loading branch information
Kuninori Morimoto authored and Rob Herring (Arm) committed Oct 24, 2024
1 parent 78cd57b commit 393194c
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions drivers/media/platform/xilinx/xilinx-tpg.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_graph.h>
#include <linux/platform_device.h>
#include <linux/xilinx-v4l2-controls.h>

Expand Down Expand Up @@ -711,22 +712,13 @@ static int xtpg_parse_of(struct xtpg_device *xtpg)
{
struct device *dev = xtpg->xvip.dev;
struct device_node *node = xtpg->xvip.dev->of_node;
struct device_node *ports;
struct device_node *port;
unsigned int nports = 0;
bool has_endpoint = false;

ports = of_get_child_by_name(node, "ports");
if (ports == NULL)
ports = node;

for_each_child_of_node(ports, port) {
for_each_of_graph_port(node, port) {
const struct xvip_video_format *format;
struct device_node *endpoint;

if (!of_node_name_eq(port, "port"))
continue;

format = xvip_of_get_format(port);
if (IS_ERR(format)) {
dev_err(dev, "invalid format in DT");
Expand All @@ -744,7 +736,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg)
}

if (nports == 0) {
endpoint = of_get_next_child(port, NULL);
endpoint = of_graph_get_next_port_endpoint(port, NULL);
if (endpoint)
has_endpoint = true;
of_node_put(endpoint);
Expand Down

0 comments on commit 393194c

Please sign in to comment.