Skip to content

Commit

Permalink
dt-bindings: fix sifive gpio properties
Browse files Browse the repository at this point in the history
The sifive gpio IP block supports up to 32 GPIOs. Reflect that in the
interrupts property description and maxItems. Also add the standard
ngpios property to describe the number of GPIOs available on the
implementation.

Also add the "canaan,k210-gpiohs" compatible string to indicate the use
of this gpio controller in the Canaan Kendryte K210 SoC. If this
compatible string is used, do not define the clocks property as
required as the K210 SoC does not have a software controllable clock
for the Sifive gpio IP block.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
  • Loading branch information
Damien Le Moal authored and Palmer Dabbelt committed Feb 23, 2021
1 parent 8fc8719 commit 3933cf6
Showing 1 changed file with 22 additions and 3 deletions.
25 changes: 22 additions & 3 deletions Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,17 @@ properties:
- enum:
- sifive,fu540-c000-gpio
- sifive,fu740-c000-gpio
- canaan,k210-gpiohs
- const: sifive,gpio0

reg:
maxItems: 1

interrupts:
description:
interrupt mapping one per GPIO. Maximum 16 GPIOs.
Interrupt mapping, one per GPIO. Maximum 32 GPIOs.
minItems: 1
maxItems: 16
maxItems: 32

interrupt-controller: true

Expand All @@ -38,6 +39,14 @@ properties:
"#gpio-cells":
const: 2

ngpios:
description:
The number of GPIOs available on the controller implementation.
It is 16 for the SiFive SoCs and 32 for the Canaan K210.
minimum: 1
maximum: 32
default: 16

gpio-controller: true

required:
Expand All @@ -46,10 +55,20 @@ required:
- interrupts
- interrupt-controller
- "#interrupt-cells"
- clocks
- "#gpio-cells"
- gpio-controller

if:
properties:
compatible:
contains:
enum:
- sifive,fu540-c000-gpio
- sifive,fu740-c000-gpio
then:
required:
- clocks

additionalProperties: false

examples:
Expand Down

0 comments on commit 3933cf6

Please sign in to comment.