Skip to content

Commit

Permalink
libata: fix unbalanced spin_lock_irqsave/spin_unlock_irq() in ata_scs…
Browse files Browse the repository at this point in the history
…i_park_show()

ata_scsi_park_show() was pairing spin_lock_irqsave() with
spin_unlock_irq().  As the function is always called with irq enabled,
it didn't actually break anything.  Use spin_lock_irq() instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Elias Oltmanns <eo@nebensachen.de>
  • Loading branch information
Tejun Heo committed Feb 18, 2016
1 parent a2127e4 commit 3948b6f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/ata/libata-scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,13 @@ static ssize_t ata_scsi_park_show(struct device *device,
struct ata_port *ap;
struct ata_link *link;
struct ata_device *dev;
unsigned long flags, now;
unsigned long now;
unsigned int uninitialized_var(msecs);
int rc = 0;

ap = ata_shost_to_port(sdev->host);

spin_lock_irqsave(ap->lock, flags);
spin_lock_irq(ap->lock);
dev = ata_scsi_find_dev(ap, sdev);
if (!dev) {
rc = -ENODEV;
Expand Down

0 comments on commit 3948b6f

Please sign in to comment.