Skip to content

Commit

Permalink
net: dsa: b53: Fix for failure when irq is not defined in dt
Browse files Browse the repository at this point in the history
Fixes the issues with non BCM58XX chips in the b53 driver
failing, when the irq is not specified in the device tree.

Removed the check for BCM58XX in b53_srab_prepare_irq(),
so the 'port->irq' will be set to '-EXIO' if the irq is not
specified in the device tree.

Fixes: 1699437 ("net: dsa: b53: Make SRAB driver manage port interrupts")
Fixes: b2ddc48 ("net: dsa: b53: Do not fail when IRQ are not initialized")
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Arun Parameswaran authored and David S. Miller committed Feb 8, 2019
1 parent ec7fd00 commit 39841cc
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/dsa/b53/b53_srab.c
Original file line number Diff line number Diff line change
Expand Up @@ -511,9 +511,6 @@ static void b53_srab_prepare_irq(struct platform_device *pdev)
/* Clear all pending interrupts */
writel(0xffffffff, priv->regs + B53_SRAB_INTR);

if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID)
return;

for (i = 0; i < B53_N_PORTS; i++) {
port = &priv->port_intrs[i];

Expand Down

0 comments on commit 39841cc

Please sign in to comment.