Skip to content

Commit

Permalink
TPM: Add new TPMs to the tail of the list to prevent inadvertent chan…
Browse files Browse the repository at this point in the history
…ge of dev

Add newly registered TPMs to the tail of the list, not the beginning, so that
things that are specifying TPM_ANY_NUM don't find that the device they're
using has inadvertently changed.  Adding a second device would break IMA, for
instance.

Cc: stable@vger.kernel.org
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
  • Loading branch information
David Howells authored and Peter Huewe committed Jan 17, 2015
1 parent bb31f60 commit 398a1e7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/tpm/tpm-interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ struct tpm_chip *tpm_register_hardware(struct device *dev,

/* Make chip available */
spin_lock(&driver_lock);
list_add_rcu(&chip->list, &tpm_chip_list);
list_add_tail_rcu(&chip->list, &tpm_chip_list);
spin_unlock(&driver_lock);

return chip;
Expand Down

0 comments on commit 398a1e7

Please sign in to comment.