Skip to content

Commit

Permalink
sched: Rate-limit nohz
Browse files Browse the repository at this point in the history
Entering nohz code on every micro-idle is costing ~10% throughput for netperf
TCP_RR when scheduling cross-cpu.  Rate limiting entry fixes this, but raises
ticks a bit.  On my Q6600, an idle box goes from ~85 interrupts/sec to 128.

The higher the context switch rate, the more nohz entry costs.  With this patch
and some cycle recovery patches in my tree, max cross cpu context switch rate is
improved by ~16%, a large portion of which of which is this ratelimiting.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1268301003.6785.28.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Mike Galbraith authored and Ingo Molnar committed Mar 11, 2010
1 parent 41acab8 commit 39c0cbe
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
6 changes: 6 additions & 0 deletions include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,17 @@ extern cpumask_var_t nohz_cpu_mask;
#if defined(CONFIG_SMP) && defined(CONFIG_NO_HZ)
extern int select_nohz_load_balancer(int cpu);
extern int get_nohz_load_balancer(void);
extern int nohz_ratelimit(int cpu);
#else
static inline int select_nohz_load_balancer(int cpu)
{
return 0;
}

static inline int nohz_ratelimit(int cpu)
{
return 0;
}
#endif

/*
Expand Down
12 changes: 12 additions & 0 deletions kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ struct rq {
#define CPU_LOAD_IDX_MAX 5
unsigned long cpu_load[CPU_LOAD_IDX_MAX];
#ifdef CONFIG_NO_HZ
u64 nohz_stamp;
unsigned char in_nohz_recently;
#endif
/* capture load from *all* tasks on this cpu: */
Expand Down Expand Up @@ -1228,6 +1229,17 @@ void wake_up_idle_cpu(int cpu)
if (!tsk_is_polling(rq->idle))
smp_send_reschedule(cpu);
}

int nohz_ratelimit(int cpu)
{
struct rq *rq = cpu_rq(cpu);
u64 diff = rq->clock - rq->nohz_stamp;

rq->nohz_stamp = rq->clock;

return diff < (NSEC_PER_SEC / HZ) >> 1;
}

#endif /* CONFIG_NO_HZ */

static u64 sched_avg_period(void)
Expand Down
3 changes: 3 additions & 0 deletions kernel/time/tick-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,9 @@ void tick_nohz_stop_sched_tick(int inidle)
goto end;
}

if (nohz_ratelimit(cpu))
goto end;

ts->idle_calls++;
/* Read jiffies and the time when jiffies were updated last */
do {
Expand Down

0 comments on commit 39c0cbe

Please sign in to comment.