Skip to content

Commit

Permalink
cpufreq: dt-platdev: eliminate uses of of_node_put()
Browse files Browse the repository at this point in the history
Make use of the __free() cleanup handler to automatically free nodes
when they get out of scope.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
  • Loading branch information
Javier Carrasco authored and Viresh Kumar committed Apr 23, 2024
1 parent 68090fd commit 39eaf52
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/cpufreq/cpufreq-dt-platdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,19 +198,18 @@ static const struct of_device_id blocklist[] __initconst = {

static bool __init cpu0_node_has_opp_v2_prop(void)
{
struct device_node *np = of_cpu_device_node_get(0);
struct device_node *np __free(device_node) = of_cpu_device_node_get(0);
bool ret = false;

if (of_property_present(np, "operating-points-v2"))
ret = true;

of_node_put(np);
return ret;
}

static int __init cpufreq_dt_platdev_init(void)
{
struct device_node *np = of_find_node_by_path("/");
struct device_node *np __free(device_node) = of_find_node_by_path("/");
const struct of_device_id *match;
const void *data = NULL;

Expand All @@ -226,11 +225,9 @@ static int __init cpufreq_dt_platdev_init(void)
if (cpu0_node_has_opp_v2_prop() && !of_match_node(blocklist, np))
goto create_pdev;

of_node_put(np);
return -ENODEV;

create_pdev:
of_node_put(np);
return PTR_ERR_OR_ZERO(platform_device_register_data(NULL, "cpufreq-dt",
-1, data,
sizeof(struct cpufreq_dt_platform_data)));
Expand Down

0 comments on commit 39eaf52

Please sign in to comment.