Skip to content

Commit

Permalink
audit: add netlink audit protocol bind to check capabilities on multi…
Browse files Browse the repository at this point in the history
…cast join

Register a netlink per-protocol bind fuction for audit to check userspace
process capabilities before allowing a multicast group connection.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Richard Guy Briggs authored and David S. Miller committed Apr 23, 2014
1 parent 7774d5e commit 3a101b8
Showing 3 changed files with 17 additions and 2 deletions.
7 changes: 6 additions & 1 deletion include/uapi/linux/capability.h
Original file line number Diff line number Diff line change
@@ -347,7 +347,12 @@ struct vfs_cap_data {

#define CAP_BLOCK_SUSPEND 36

#define CAP_LAST_CAP CAP_BLOCK_SUSPEND
/* Allow reading the audit log via multicast netlink socket */

#define CAP_AUDIT_READ 37


#define CAP_LAST_CAP CAP_AUDIT_READ

#define cap_valid(x) ((x) >= 0 && (x) <= CAP_LAST_CAP)

10 changes: 10 additions & 0 deletions kernel/audit.c
Original file line number Diff line number Diff line change
@@ -1076,10 +1076,20 @@ static void audit_receive(struct sk_buff *skb)
mutex_unlock(&audit_cmd_mutex);
}

/* Run custom bind function on netlink socket group connect or bind requests. */
static int audit_bind(int group)
{
if (!capable(CAP_AUDIT_READ))
return -EPERM;

return 0;
}

static int __net_init audit_net_init(struct net *net)
{
struct netlink_kernel_cfg cfg = {
.input = audit_receive,
.bind = audit_bind,
};

struct audit_net *aunet = net_generic(net, audit_net_id);
2 changes: 1 addition & 1 deletion security/selinux/include/classmap.h
Original file line number Diff line number Diff line change
@@ -147,7 +147,7 @@ struct security_class_mapping secclass_map[] = {
{ "peer", { "recv", NULL } },
{ "capability2",
{ "mac_override", "mac_admin", "syslog", "wake_alarm", "block_suspend",
NULL } },
"audit_read", NULL } },
{ "kernel_service", { "use_as_override", "create_files_as", NULL } },
{ "tun_socket",
{ COMMON_SOCK_PERMS, "attach_queue", NULL } },

0 comments on commit 3a101b8

Please sign in to comment.