ovl: add WARN_ON() for non-dir redirect cases

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
mariux64 · Apr 12, 2018 · 3a29177 · 3a29177
1 parent 0471a9c
commit 3a29177
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
@@ -256,6 +256,12 @@ static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
 		d->stop = true;
 		if (d->is_dir)
 			goto put_and_out;
+
+		/*
+		 * NB: handle failure to lookup non-last element when non-dir
+		 * redirects become possible
+		 */
+		WARN_ON(!last_element);
 		goto out;
 	}
 	if (last_element)
@@ -1006,6 +1012,11 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
 		if (IS_ERR(inode))
 			goto out_free_oe;
 
+		/*
+		 * NB: handle redirected hard links when non-dir redirects
+		 * become possible
+		 */
+		WARN_ON(OVL_I(inode)->redirect);
 		OVL_I(inode)->redirect = upperredirect;
 	}