Skip to content

Commit

Permalink
soc: imx: gpc: fix the wrong using of regmap cache
Browse files Browse the repository at this point in the history
Without providing the proper reg_defaults, the regmap registers first
read out may be always 0 if enabling cache, which results in the
following issue we met.
e.g. During driver probe in imx6_pm_domain_power_on():
regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PUPSCR_OFFS, &val);
The PGC_PUPSCR register val is always 0 but it's actually 0xf01 in HW.

Since GPC registers are tightly related to CPU bring up and may be
changed in bootloader, we don't want to provide defaults.
And the cache really does not save too much for GPC module.

Therefore, simply disable cache to fix the issue and make life easy.

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Fixes: 721cabf ("soc: imx: move PGC handling to a new GPC driver")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
  • Loading branch information
Dong Aisheng authored and Shawn Guo committed Mar 24, 2017
1 parent 55b0baa commit 3a317f5
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/soc/imx/gpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,22 +289,12 @@ static bool imx_gpc_readable_reg(struct device *dev, unsigned int reg)
return (reg % 4 == 0) && (reg <= 0x2ac);
}

static bool imx_gpc_volatile_reg(struct device *dev, unsigned int reg)
{
if (reg == GPC_CNTR)
return true;

return false;
}

static const struct regmap_config imx_gpc_regmap_config = {
.cache_type = REGCACHE_FLAT,
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,

.readable_reg = imx_gpc_readable_reg,
.volatile_reg = imx_gpc_volatile_reg,

.max_register = 0x2ac,
};
Expand Down

0 comments on commit 3a317f5

Please sign in to comment.