Skip to content

Commit

Permalink
um: Use RWSEM_GENERIC_SPINLOCK on x86
Browse files Browse the repository at this point in the history
Commit d12337 (rwsem: Remove redundant asmregparm annotation)
broke rwsem on UML.

As we cannot compile UML with -mregparm=3 and keeping asmregparm only
for UML is inadequate the easiest solution is using RWSEM_GENERIC_SPINLOCK.

Thanks to Thomas Gleixner for the idea.

Reported-by: Toralf Förster <toralf.foerster@gmx.de>
Tested-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: <stable@kernel.org> # .39.x
Link: http://lkml.kernel.org/r/%3C1306183893-26655-1-git-send-email-richard%40nod.at%3E
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Richard Weinberger authored and Thomas Gleixner committed May 24, 2011
1 parent d762f43 commit 3a36790
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/um/Kconfig.x86
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ config X86_64
def_bool 64BIT

config RWSEM_XCHGADD_ALGORITHM
def_bool X86_XADD
def_bool X86_XADD && 64BIT

config RWSEM_GENERIC_SPINLOCK
def_bool !X86_XADD
def_bool !RWSEM_XCHGADD_ALGORITHM

config 3_LEVEL_PGTABLES
bool "Three-level pagetables (EXPERIMENTAL)" if !64BIT
Expand Down

0 comments on commit 3a36790

Please sign in to comment.