Skip to content

Commit

Permalink
media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad()
Browse files Browse the repository at this point in the history
While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
sinks, the check is_media_entity_v4l2_subdev() was not removed which
prevented the function from being used with non-subdev sinks, Drop the
unnecessary check.

Fixes: bd5a03b ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")
Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
  • Loading branch information
Vaishnav Achath authored and Mauro Carvalho Chehab committed Jun 2, 2023
1 parent a05e9aa commit 3a4cdef
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/media/v4l2-core/v4l2-mc.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
{
struct fwnode_handle *endpoint;

if (!(sink->flags & MEDIA_PAD_FL_SINK) ||
!is_media_entity_v4l2_subdev(sink->entity))
if (!(sink->flags & MEDIA_PAD_FL_SINK))
return -EINVAL;

fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {
Expand Down

0 comments on commit 3a4cdef

Please sign in to comment.