Skip to content

Commit

Permalink
fuse: kill req->intr_unique
Browse files Browse the repository at this point in the history
This field is not needed after the previous patch, since we can easily
convert request ID to interrupt request ID and vice versa.

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
  • Loading branch information
Kirill Tkhai authored and Miklos Szeredi committed Sep 28, 2018
1 parent c59fd85 commit 3a5358d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
11 changes: 5 additions & 6 deletions fs/fuse/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1095,12 +1095,11 @@ __releases(fiq->waitq.lock)
int err;

list_del_init(&req->intr_entry);
req->intr_unique = (req->in.h.unique | FUSE_INT_REQ_BIT);
memset(&ih, 0, sizeof(ih));
memset(&arg, 0, sizeof(arg));
ih.len = reqsize;
ih.opcode = FUSE_INTERRUPT;
ih.unique = req->intr_unique;
ih.unique = (req->in.h.unique | FUSE_INT_REQ_BIT);
arg.unique = req->in.h.unique;

spin_unlock(&fiq->waitq.lock);
Expand Down Expand Up @@ -1808,7 +1807,7 @@ static struct fuse_req *request_find(struct fuse_pqueue *fpq, u64 unique)
struct fuse_req *req;

list_for_each_entry(req, &fpq->processing, list) {
if (req->in.h.unique == unique || req->intr_unique == unique)
if (req->in.h.unique == unique)
return req;
}
return NULL;
Expand Down Expand Up @@ -1882,12 +1881,12 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud,
if (!fpq->connected)
goto err_unlock_pq;

req = request_find(fpq, oh.unique);
req = request_find(fpq, oh.unique & ~FUSE_INT_REQ_BIT);
if (!req)
goto err_unlock_pq;

/* Is it an interrupt reply? */
if (req->intr_unique == oh.unique) {
/* Is it an interrupt reply ID? */
if (oh.unique & FUSE_INT_REQ_BIT) {
__fuse_get_request(req);
spin_unlock(&fpq->lock);

Expand Down
3 changes: 0 additions & 3 deletions fs/fuse/fuse_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,6 @@ struct fuse_req {
/** refcount */
refcount_t count;

/** Unique ID for the interrupt request */
u64 intr_unique;

/* Request flags, updated with test/set/clear_bit() */
unsigned long flags;

Expand Down

0 comments on commit 3a5358d

Please sign in to comment.