Skip to content

Commit

Permalink
net: ethernet: ave: Remove duplicate phy_resume() calls
Browse files Browse the repository at this point in the history
ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no
need to call phy_resume() explicitly. Remove it.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Link: https://lore.kernel.org/r/20221024072314.24969-1-hayashi.kunihiko@socionext.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Kunihiko Hayashi authored and Jakub Kicinski committed Oct 27, 2022
1 parent b65ef50 commit 3a6573b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/net/ethernet/socionext/sni_ave.c
Original file line number Diff line number Diff line change
Expand Up @@ -1760,12 +1760,6 @@ static int ave_resume(struct device *dev)
wol.wolopts = priv->wolopts;
__ave_ethtool_set_wol(ndev, &wol);

if (ndev->phydev) {
ret = phy_resume(ndev->phydev);
if (ret)
return ret;
}

if (netif_running(ndev)) {
ret = ave_open(ndev);
netif_device_attach(ndev);
Expand Down

0 comments on commit 3a6573b

Please sign in to comment.