Skip to content

Commit

Permalink
staging: unisys: visorbus: get rid of shouting SPAR_VBUS_CHANNEL_CLIE…
Browse files Browse the repository at this point in the history
…NT_OK macro

The macro SPAR_VBUS_CHANNEL_CLIENT_OK was noisy and only used in one place
so get rid of it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
David Kershner authored and Greg Kroah-Hartman committed Mar 29, 2017
1 parent 738561a commit 3a6b850
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
8 changes: 0 additions & 8 deletions drivers/staging/unisys/visorbus/vbuschannel.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,6 @@ static const uuid_le spar_vbus_channel_protocol_uuid =
*/
#define SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID 1

#define SPAR_VBUS_CHANNEL_OK_CLIENT(ch) \
spar_check_channel_client(ch, \
spar_vbus_channel_protocol_uuid, \
"vbus", \
sizeof(struct spar_vbus_channel_protocol), \
SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID, \
SPAR_VBUS_CHANNEL_PROTOCOL_SIGNATURE)

/*
* An array of this struct is present in the channel area for each vbus.
* (See vbuschannel.h.)
Expand Down
8 changes: 7 additions & 1 deletion drivers/staging/unisys/visorbus/visorbus_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,13 @@ static int
get_vbus_header_info(struct visorchannel *chan,
struct spar_vbus_headerinfo *hdr_info)
{
if (!SPAR_VBUS_CHANNEL_OK_CLIENT(visorchannel_get_header(chan)))
if (!spar_check_channel_client(visorchannel_get_header(chan),
spar_vbus_channel_protocol_uuid,
"vbus",
sizeof
(struct spar_vbus_channel_protocol),
SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID,
SPAR_VBUS_CHANNEL_PROTOCOL_SIGNATURE))
return -EINVAL;

if (visorchannel_read(chan, sizeof(struct channel_header), hdr_info,
Expand Down

0 comments on commit 3a6b850

Please sign in to comment.