Skip to content

Commit

Permalink
can: sja1000: remove redundant variable ret
Browse files Browse the repository at this point in the history
Return value directly from register_candev() instead of
getting value from redundant variable ret.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Link: https://lore.kernel.org/all/20220831161835.306079-1-cui.jinpeng2@zte.com.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Jinpeng Cui authored and Marc Kleine-Budde committed Sep 5, 2022
1 parent 0838921 commit 3a71eba
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/net/can/sja1000/sja1000.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,6 @@ static const struct ethtool_ops sja1000_ethtool_ops = {

int register_sja1000dev(struct net_device *dev)
{
int ret;

if (!sja1000_probe_chip(dev))
return -ENODEV;

Expand All @@ -673,9 +671,7 @@ int register_sja1000dev(struct net_device *dev)
set_reset_mode(dev);
chipset_init(dev);

ret = register_candev(dev);

return ret;
return register_candev(dev);
}
EXPORT_SYMBOL_GPL(register_sja1000dev);

Expand Down

0 comments on commit 3a71eba

Please sign in to comment.