Skip to content

Commit

Permalink
r8169: remove not needed check in rtl_fw_write_firmware
Browse files Browse the repository at this point in the history
This check can never be true for a firmware file with a correct format.
Existing checks in rtl_fw_data_ok() are sufficient, no problems with
invalid firmware files are known.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Nov 24, 2023
1 parent 30c9020 commit 3a767b4
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/realtek/r8169_firmware.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ void rtl_fw_write_firmware(struct rtl8169_private *tp, struct rtl_fw *rtl_fw)
u32 regno = (action & 0x0fff0000) >> 16;
enum rtl_fw_opcode opcode = action >> 28;

if (!action)
break;

switch (opcode) {
case PHY_READ:
predata = fw_read(tp, regno);
Expand Down

0 comments on commit 3a767b4

Please sign in to comment.