Skip to content

Commit

Permalink
netlink: specs: ovs: remove fixed header fields from attrs
Browse files Browse the repository at this point in the history
Op's "attributes" list is a workaround for families with a single
attr set. We don't want to render a single huge request structure,
the same for each op since we know that most ops accept only a small
set of attributes. "Attributes" list lets us narrow down the attributes
to what op acctually pays attention to.

It doesn't make sense to put names of fixed headers in there.
They are not "attributes" and we can't really narrow down the struct
members.

Remove the fixed header fields from attrs for ovs families
in preparation for C codegen support.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jakub Kicinski authored and David S. Miller committed Dec 15, 2023
1 parent 283f105 commit 3ada0b3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
2 changes: 0 additions & 2 deletions Documentation/netlink/specs/ovs_datapath.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ operations:
do:
request:
attributes:
- dp-ifindex
- name
- upcall-pid
- user-features
Expand All @@ -154,7 +153,6 @@ operations:
do:
request:
attributes:
- dp-ifindex
- name

mcast-groups:
Expand Down
3 changes: 0 additions & 3 deletions Documentation/netlink/specs/ovs_flow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -947,13 +947,11 @@ operations:
do: &flow-get-op
request:
attributes:
- dp-ifindex
- key
- ufid
- ufid-flags
reply:
attributes:
- dp-ifindex
- key
- ufid
- mask
Expand All @@ -968,7 +966,6 @@ operations:
do:
request:
attributes:
- dp-ifindex
- key
- ufid
- mask
Expand Down
4 changes: 0 additions & 4 deletions Documentation/netlink/specs/ovs_vport.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ operations:
- name
- type
- upcall-pid
- dp-ifindex
- ifindex
- options
-
Expand All @@ -146,7 +145,6 @@ operations:
do:
request:
attributes:
- dp-ifindex
- port-no
- type
- name
Expand All @@ -158,11 +156,9 @@ operations:
do: &vport-get-op
request:
attributes:
- dp-ifindex
- name
reply: &dev-all
attributes:
- dp-ifindex
- port-no
- type
- name
Expand Down

0 comments on commit 3ada0b3

Please sign in to comment.