Skip to content

Commit

Permalink
tpm_crb: remove a cruft constant
Browse files Browse the repository at this point in the history
Remove a useless constant that slipped through me when I did the code
review. This commit fixes the issue.

Cc: Jiandi An <anjiandi@codeaurora.org>
Fixes: 69c558de63c7 ("tpm/tpm_crb: Enable TPM CRB interface for ARM64")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
  • Loading branch information
Jarkko Sakkinen committed Apr 24, 2017
1 parent f65cc10 commit 3b395d6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/char/tpm/tpm_crb.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,7 @@ static int crb_acpi_add(struct acpi_device *device)
ACPI_TPM2_COMMAND_BUFFER_WITH_SMC);
return -EINVAL;
}
crb_smc = ACPI_ADD_PTR(struct tpm2_crb_smc, buf,
ACPI_TPM2_START_METHOD_PARAMETER_OFFSET);
crb_smc = ACPI_ADD_PTR(struct tpm2_crb_smc, buf, sizeof(*buf));
priv->smc_func_id = crb_smc->smc_func_id;
priv->flags |= CRB_FL_CRB_SMC_START;
}
Expand Down
2 changes: 0 additions & 2 deletions include/acpi/actbl2.h
Original file line number Diff line number Diff line change
Expand Up @@ -1296,8 +1296,6 @@ struct acpi_table_tpm2 {
#define ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD 8
#define ACPI_TPM2_COMMAND_BUFFER_WITH_SMC 11

#define ACPI_TPM2_START_METHOD_PARAMETER_OFFSET 52

/*******************************************************************************
*
* UEFI - UEFI Boot optimization Table
Expand Down

0 comments on commit 3b395d6

Please sign in to comment.