Skip to content

Commit

Permalink
EDAC, mv64x60: Sanity check edac_op_state before registering
Browse files Browse the repository at this point in the history
edac_op_state is a module parameter which affects the behaviour of
the driver probe which can potentially be invoked as soon as the
platform driver registration happens. Because of this we need to
ensure that we sanity check the module parameter before calling
platform_register_drivers().

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170607215530.8604-1-chris.packham@alliedtelesis.co.nz
Signed-off-by: Borislav Petkov <bp@suse.de>
  • Loading branch information
Chris Packham authored and Borislav Petkov committed Jun 9, 2017
1 parent cf97825 commit 3b405e3
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/edac/mv64x60_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -853,11 +853,6 @@ static struct platform_driver * const drivers[] = {

static int __init mv64x60_edac_init(void)
{
int ret;

ret = platform_register_drivers(drivers, ARRAY_SIZE(drivers));
if (ret)
return ret;

printk(KERN_INFO "Marvell MV64x60 EDAC driver " MV64x60_REVISION "\n");
printk(KERN_INFO "\t(C) 2006-2007 MontaVista Software\n");
Expand All @@ -872,7 +867,7 @@ static int __init mv64x60_edac_init(void)
break;
}

return 0;
return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
}
module_init(mv64x60_edac_init);

Expand Down

0 comments on commit 3b405e3

Please sign in to comment.