Skip to content

Commit

Permalink
lan78xx: remove redundant initialization of pointer 'phydev'
Browse files Browse the repository at this point in the history
Pointer phydev is initialized and this value is never read, phydev
is immediately updated to a new value, hence this initialization
is redundant and can be removed

Cleans up clang warning:
drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Colin Ian King authored and David S. Miller committed Feb 1, 2018
1 parent f14d244 commit 3b51cc7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/usb/lan78xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2006,7 +2006,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
{
int ret;
u32 mii_adv;
struct phy_device *phydev = dev->net->phydev;
struct phy_device *phydev;

phydev = phy_find_first(dev->mdiobus);
if (!phydev) {
Expand Down

0 comments on commit 3b51cc7

Please sign in to comment.