Skip to content

Commit

Permalink
genirq: Remove bogus conditional
Browse files Browse the repository at this point in the history
The if (chip->irq_shutdown) check will always evaluate to true, as we
fill in chip->irq_shutdown with default_shutdown in
irq_chip_set_defaults() if the chip does not provide its own function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <20110202212551.667607458@linutronix.de>
  • Loading branch information
Thomas Gleixner committed Feb 19, 2011
1 parent 1535dfa commit 3b56f05
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions kernel/irq/manage.c
Original file line number Diff line number Diff line change
Expand Up @@ -1057,10 +1057,7 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id)
/* If this was the last handler, shut down the IRQ line: */
if (!desc->action) {
desc->status |= IRQ_DISABLED;
if (desc->irq_data.chip->irq_shutdown)
desc->irq_data.chip->irq_shutdown(&desc->irq_data);
else
desc->irq_data.chip->irq_disable(&desc->irq_data);
desc->irq_data.chip->irq_shutdown(&desc->irq_data);
}

#ifdef CONFIG_SMP
Expand Down

0 comments on commit 3b56f05

Please sign in to comment.