Skip to content

Commit

Permalink
ACPI/x86: revert 'x86, acpi: Call acpi_enter_sleep_state via an asmli…
Browse files Browse the repository at this point in the history
…nkage C function from assembler'

cd74257
patched up GTS/BFS -- a feature we want to remove.
So revert it (by hand, due to conflict in sleep.h)
to prepare for GTS/BFS removal.

Signed-off-by: Len Brown <len.brown@intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Len Brown committed Jul 31, 2012
1 parent ec033d0 commit 3b6961b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
4 changes: 0 additions & 4 deletions arch/x86/kernel/acpi/sleep.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ unsigned long acpi_realmode_flags;
static char temp_stack[4096];
#endif

asmlinkage void acpi_enter_s3(void)
{
acpi_enter_sleep_state(3, wake_sleep_flags);
}
/**
* acpi_suspend_lowlevel - save kernel state
*
Expand Down
2 changes: 0 additions & 2 deletions arch/x86/kernel/acpi/sleep.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* Variables and functions used by the code in sleep.c
*/

#include <linux/linkage.h>
#include <asm/realmode.h>

extern unsigned long saved_video_mode;
Expand All @@ -11,7 +10,6 @@ extern long saved_magic;
extern int wakeup_pmode_return;

extern u8 wake_sleep_flags;
extern asmlinkage void acpi_enter_s3(void);

extern unsigned long acpi_copy_wakeup_routine(unsigned long);
extern void wakeup_long64(void);
Expand Down
4 changes: 3 additions & 1 deletion arch/x86/kernel/acpi/wakeup_32.S
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ restore_registers:
ENTRY(do_suspend_lowlevel)
call save_processor_state
call save_registers
call acpi_enter_s3
pushl $3
call acpi_enter_sleep_state
addl $4, %esp

# In case of S3 failure, we'll emerge here. Jump
# to ret_point to recover
Expand Down
4 changes: 3 additions & 1 deletion arch/x86/kernel/acpi/wakeup_64.S
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ ENTRY(do_suspend_lowlevel)
movq %rsi, saved_rsi

addq $8, %rsp
call acpi_enter_s3
movl $3, %edi
xorl %eax, %eax
call acpi_enter_sleep_state
/* in case something went wrong, restore the machine status and go on */
jmp resume_point

Expand Down

0 comments on commit 3b6961b

Please sign in to comment.